Commit 2d146eb1 authored Jan 19, 2010 by Ram Vepa Committed by David S. Miller Jan 19, 2010

S2io: two branches the same in wait_for_cmd_complete()



Fix check to verify if a register bit is set. We have not hit this bug because
wait_for_cmd_complete() is always called with S2IO_BIT_RESET. 
Reported by Roel Kluin <roel.kluin@gmail.com>.

Signed-off-by: Ram Vepa <ram.vepa@neterion.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent dad48a4e

drivers/net/s2io.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3421,7 +3421,7 @@ static int wait_for_cmd_complete(void __iomem *addr, u64 busy_bit,
		break;
		}
		} else {
		if (!(val64 & busy_bit)) {
		if (val64 & busy_bit) {
		ret = SUCCESS;
		break;
		}

Admin message