Commit 2d09e6eb authored by Saravana Kannan's avatar Saravana Kannan Committed by Greg Kroah-Hartman
Browse files

driver core: Delete pointless parameter in fwnode_operations.add_links 



The struct device input to add_links() is not used for anything. So
delete it.

Acked-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarSaravana Kannan <saravanak@google.com>
Link: https://lore.kernel.org/r/20201121020232.908850-18-saravanak@google.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f9aa4606

drivers/base/core.c

+1 −1
Original line number Diff line number Diff line
@@ -1472,7 +1472,7 @@ static void fw_devlink_parse_fwnode(struct fwnode_handle *fwnode) 
	if (fwnode->flags & FWNODE_FLAG_LINKS_ADDED)

		return;



	fwnode_call_int_op(fwnode, add_links, NULL);

	fwnode_call_int_op(fwnode, add_links);

	fwnode->flags |= FWNODE_FLAG_LINKS_ADDED;

}

drivers/firmware/efi/efi-init.c

+1 −2
Original line number Diff line number Diff line
@@ -316,8 +316,7 @@ static struct device_node *find_pci_overlap_node(void) 
 * resource reservation conflict on the memory window that the efifb

 * framebuffer steals from the PCIe host bridge.

 */

static int efifb_add_links(struct fwnode_handle *fwnode,

			   struct device *dev)

static int efifb_add_links(struct fwnode_handle *fwnode)

{

	struct device_node *sup_np;

drivers/of/property.c

+1 −2
Original line number Diff line number Diff line
@@ -1343,8 +1343,7 @@ static int of_link_property(struct device_node *con_np, const char *prop_name) 
	return ret;

}



static int of_fwnode_add_links(struct fwnode_handle *fwnode,

			       struct device *dev)

static int of_fwnode_add_links(struct fwnode_handle *fwnode)

{

	struct property *p;

	struct device_node *con_np = to_of_node(fwnode);

include/linux/fwnode.h

+1 −2
Original line number Diff line number Diff line
@@ -127,8 +127,7 @@ struct fwnode_operations { 
	(*graph_get_port_parent)(struct fwnode_handle *fwnode);

	int (*graph_parse_endpoint)(const struct fwnode_handle *fwnode,

				    struct fwnode_endpoint *endpoint);

	int (*add_links)(struct fwnode_handle *fwnode,

			 struct device *dev);

	int (*add_links)(struct fwnode_handle *fwnode);

};



#define fwnode_has_op(fwnode, op)				\

CRA Git | Maintained and supported by SUSTech CRA and CCSE