cifs: Fix support for remount when not changing rsize/wsize (2d060493) · Commits · 戴 / test

When remounting with the new mount API, we need to set rsize and wsize to the previous values if they are not passed in on the remount. Otherwise they get set to zero which breaks xfstest 452 for example. Signed-off-by:

Steve French <stfrench@microsoft.com> Reviewed-by:

Ronnie Sahlberg <lsahlber@redhat.com> Reviewed-by:

Shyam Prasad N <sprasad@microsoft.com>

fs/cifs/fs_context.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -707,6 +707,13 @@ static int smb3_reconfigure(struct fs_context *fc)
		STEAL_STRING(cifs_sb, ctx, nodename);
		STEAL_STRING(cifs_sb, ctx, iocharset);

		/* if rsize or wsize not passed in on remount, use previous values */
		if (ctx->rsize == 0)
		ctx->rsize = cifs_sb->ctx->rsize;
		if (ctx->wsize == 0)
		ctx->wsize = cifs_sb->ctx->wsize;


		smb3_cleanup_fs_context_contents(cifs_sb->ctx);
		rc = smb3_fs_context_dup(cifs_sb->ctx, ctx);
		smb3_update_mnt_flags(cifs_sb);

Admin message