Unverified Commit 2cfdc24d authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/sun4i: dsi: Fix front vs back porch calculation 



Since I always confuse the back and front porches, a few miscalculation
slipped through. Fix them.

Signed-off-by: default avatarMaxime Ripard <maxime.ripard@bootlin.com>
Reviewed-by: default avatarPaul Kocialkowski <paul.kocialkowski@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/90c2375b8a853cae0dcc135cedb47edbc26168d8.1549896081.git-series.maxime.ripard@bootlin.com
parent efa31801

drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c

+4 −4
Original line number Diff line number Diff line
@@ -478,7 +478,7 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi, 
	 */

#define HBP_PACKET_OVERHEAD	6

	hbp = max((unsigned int)HBP_PACKET_OVERHEAD,

		  (mode->hsync_start - mode->hdisplay) * Bpp - HBP_PACKET_OVERHEAD);

		  (mode->htotal - mode->hsync_end) * Bpp - HBP_PACKET_OVERHEAD);



	/*

	 * The frontporch is set using a blanking packet (4 bytes +
@@ -486,7 +486,7 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi, 
	 */

#define HFP_PACKET_OVERHEAD	6

	hfp = max((unsigned int)HFP_PACKET_OVERHEAD,

		  (mode->htotal - mode->hsync_end) * Bpp - HFP_PACKET_OVERHEAD);

		  (mode->hsync_start - mode->hdisplay) * Bpp - HFP_PACKET_OVERHEAD);



	/*

	 * hblk seems to be the line + porches length.
@@ -532,8 +532,8 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi, 
	regmap_write(dsi->regs, SUN6I_DSI_BASIC_SIZE0_REG,

		     SUN6I_DSI_BASIC_SIZE0_VSA(mode->vsync_end -

					       mode->vsync_start) |

		     SUN6I_DSI_BASIC_SIZE0_VBP(mode->vsync_start -

					       mode->vdisplay));

		     SUN6I_DSI_BASIC_SIZE0_VBP(mode->vtotal -

					       mode->vsync_end));



	regmap_write(dsi->regs, SUN6I_DSI_BASIC_SIZE1_REG,

		     SUN6I_DSI_BASIC_SIZE1_VACT(mode->vdisplay) |

CRA Git | Maintained and supported by SUSTech CRA and CCSE