Commit 2cd05cc3 authored by Theodore Ts'o's avatar Theodore Ts'o
Browse files

ext4: remove unneeded ext4_journal_get_undo_access 



The block allocation code used to use jbd2_journal_get_undo_access as
a way to make changes that wouldn't show up until the commit took
place.  The new multi-block allocation code has a its own way of
preventing newly freed blocks from getting reused until the commit
takes place (it avoids updating the buddy bitmaps until the commit is
done), so we don't need to use jbd2_journal_get_undo_access(), which
has extra overhead compared to jbd2_journal_get_write_access().

There was one last vestigal use of ext4_journal_get_undo_access() in
ext4_add_groupblocks(); change it to use ext4_journal_get_write_access()
and then remove the ext4_journal_get_undo_access() support.

Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent 2846e820

fs/ext4/ext4_jbd2.c

+0 −14
Original line number Diff line number Diff line
@@ -6,20 +6,6 @@ 


#include <trace/events/ext4.h>



int __ext4_journal_get_undo_access(const char *where, unsigned int line,

				   handle_t *handle, struct buffer_head *bh)

{

	int err = 0;



	if (ext4_handle_valid(handle)) {

		err = jbd2_journal_get_undo_access(handle, bh);

		if (err)

			ext4_journal_abort_handle(where, line, __func__, bh,

						  handle, err);

	}

	return err;

}



int __ext4_journal_get_write_access(const char *where, unsigned int line,

				    handle_t *handle, struct buffer_head *bh)

{

fs/ext4/ext4_jbd2.h

+0 −5
Original line number Diff line number Diff line
@@ -126,9 +126,6 @@ void ext4_journal_abort_handle(const char *caller, unsigned int line, 
			       const char *err_fn,

		struct buffer_head *bh, handle_t *handle, int err);



int __ext4_journal_get_undo_access(const char *where, unsigned int line,

				   handle_t *handle, struct buffer_head *bh);



int __ext4_journal_get_write_access(const char *where, unsigned int line,

				    handle_t *handle, struct buffer_head *bh);
@@ -146,8 +143,6 @@ int __ext4_handle_dirty_metadata(const char *where, unsigned int line, 
int __ext4_handle_dirty_super(const char *where, unsigned int line,

			      handle_t *handle, struct super_block *sb);



#define ext4_journal_get_undo_access(handle, bh) \

	__ext4_journal_get_undo_access(__func__, __LINE__, (handle), (bh))

#define ext4_journal_get_write_access(handle, bh) \

	__ext4_journal_get_write_access(__func__, __LINE__, (handle), (bh))

#define ext4_forget(handle, is_metadata, inode, bh, block_nr) \

fs/ext4/mballoc.c

+4 −8
Original line number Diff line number Diff line
@@ -4732,9 +4732,9 @@ void ext4_add_groupblocks(handle_t *handle, struct super_block *sb, 
	 * Check to see if we are freeing blocks across a group

	 * boundary.

	 */

	if (bit + count > EXT4_BLOCKS_PER_GROUP(sb)) {

	if (bit + count > EXT4_BLOCKS_PER_GROUP(sb))

		goto error_return;

	}



	bitmap_bh = ext4_read_block_bitmap(sb, block_group);

	if (!bitmap_bh)

		goto error_return;
@@ -4753,12 +4753,8 @@ void ext4_add_groupblocks(handle_t *handle, struct super_block *sb, 
		goto error_return;

	}



	/*

	 * We are about to add blocks to the bitmap,

	 * so we need undo access.

	 */

	BUFFER_TRACE(bitmap_bh, "getting undo access");

	err = ext4_journal_get_undo_access(handle, bitmap_bh);

	BUFFER_TRACE(bitmap_bh, "getting write access");

	err = ext4_journal_get_write_access(handle, bitmap_bh);

	if (err)

		goto error_return;

CRA Git | Maintained and supported by SUSTech CRA and CCSE