Commit 2c9d8e1a authored Jun 03, 2020 by Alexandru Ardelean Committed by Jonathan Cameron Jun 14, 2020

iio: light: lm3533-als: use iio_device_set_parent() to assign parent



This assignment is the more peculiar as it assigns the parent of the
platform-device's device (i.e. pdev->dev.parent) as the IIO device's
parent.

Since the devm_iio_device_alloc() [now] assigns the device argument as the
default parent (and since this is the more common case), for cases
where the parent needs to be different, the iio_device_set_parent helper
should be used.

That makes things a bit more obvious about the new behavior of
devm_iio_device_alloc() and makes it clearer that iio_device_set_parent()
should be used.

Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent 2cbd5412

drivers/iio/light/lm3533-als.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -852,7 +852,7 @@ static int lm3533_als_probe(struct platform_device *pdev)
		indio_dev->channels = lm3533_als_channels;
		indio_dev->num_channels = ARRAY_SIZE(lm3533_als_channels);
		indio_dev->name = dev_name(&pdev->dev);
		indio_dev->dev.parent = pdev->dev.parent;
		iio_device_set_parent(indio_dev, pdev->dev.parent);
		indio_dev->modes = INDIO_DIRECT_MODE;

		als = iio_priv(indio_dev);

Admin message