Commit 2c86c7ca authored Mar 17, 2014 by Namhyung Kim Committed by Arnaldo Carvalho de Melo Mar 18, 2014

perf report: Merge al->filtered with hist_entry->filtered



I.e. don't drop al->filtered entries, create the hist_entries and use
its ->filtered bitmap, that is kept with the same semantics for its
bitmap, leaving the filtering to be done at the hist_entry level, i.e.
in the UIs.

This will allow zooming in/out the filters.

Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/n/tip-xeyhkepu7plw716lrtb0zlnu@git.kernel.org


[ yanked this out of a previous patch ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 466fa764

tools/perf/builtin-report.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -231,7 +231,7 @@ static int process_sample_event(struct perf_tool *tool,
		return -1;
		}

		if (al.filtered \|\| (rep->hide_unresolved && al.sym == NULL))
		if (rep->hide_unresolved && al.sym == NULL)
		return 0;

		if (rep->cpu_list && !test_bit(sample->cpu, rep->cpu_bitmap))

tools/perf/util/hist.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -422,7 +422,7 @@ struct hist_entry __hists__add_entry(struct hists hists,
		.weight = weight,
		},
		.parent = sym_parent,
		.filtered = symbol__parent_filter(sym_parent),
		.filtered = symbol__parent_filter(sym_parent) \| al->filtered,
		.hists = hists,
		.branch_info = bi,
		.mem_info = mi,

Admin message