Commit 2c7d132a authored Jul 30, 2013 by Rafael J. Wysocki

ACPI / PM: Only set power states of devices that are power manageable



Make acpi_device_set_power() check if the given device is power
manageable before checking if the given power state is valid for that
device.  Otherwise it will print that "Device does not support" that
power state into the kernel log, which may not make sense for some
power states (D0 and D3cold are supported by all devices by
definition).

Tested-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 5ae90d8e

drivers/acpi/device_pm.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -159,7 +159,8 @@ int acpi_device_set_power(struct acpi_device *device, int state)
		int result = 0;
		bool cut_power = false;

		if (!device \|\| (state < ACPI_STATE_D0) \|\| (state > ACPI_STATE_D3_COLD))
		if (!device \|\| !device->flags.power_manageable
		\|\| (state < ACPI_STATE_D0) \|\| (state > ACPI_STATE_D3_COLD))
		return -EINVAL;

		/* Make sure this is a valid target state */

Admin message