Unverified Commit 2c55f0be authored by Kuninori Morimoto's avatar Kuninori Morimoto Committed by Mark Brown
Browse files

ASoC: pxa: pxa-ssp: move .suspend/.resume to component 



There is no big difference at implementation for .suspend/.resume
between DAI driver and Component driver.
But because some driver is using DAI version, thus ALSA SoC needs
to keep supporting it, hence, framework becoming verbose.
If we can swtcih all DAI driver .suspend/.resume to Component driver,
we can remove verbose code from ALSA SoC.

Driver is getting its private data via dai->dev.
But dai->dev and component->dev are same dev, thus, we can convert
these. For same reason, we can convert dai->active to
component->active if necessary.

This patch moves DAI driver .suspend/.resume to Component driver

Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87tv4rx7ij.wl-kuninori.morimoto.gx@renesas.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 2db023cd

sound/soc/pxa/pxa-ssp.c

+8 −8
Original line number Diff line number Diff line
@@ -133,12 +133,12 @@ static void pxa_ssp_shutdown(struct snd_pcm_substream *substream, 


#ifdef CONFIG_PM



static int pxa_ssp_suspend(struct snd_soc_dai *cpu_dai)

static int pxa_ssp_suspend(struct snd_soc_component *component)

{

	struct ssp_priv *priv = snd_soc_dai_get_drvdata(cpu_dai);

	struct ssp_priv *priv = snd_soc_component_get_drvdata(component);

	struct ssp_device *ssp = priv->ssp;



	if (!cpu_dai->active)

	if (!component->active)

		clk_prepare_enable(ssp->clk);



	priv->cr0 = __raw_readl(ssp->mmio_base + SSCR0);
@@ -151,9 +151,9 @@ static int pxa_ssp_suspend(struct snd_soc_dai *cpu_dai) 
	return 0;

}



static int pxa_ssp_resume(struct snd_soc_dai *cpu_dai)

static int pxa_ssp_resume(struct snd_soc_component *component)

{

	struct ssp_priv *priv = snd_soc_dai_get_drvdata(cpu_dai);

	struct ssp_priv *priv = snd_soc_component_get_drvdata(component);

	struct ssp_device *ssp = priv->ssp;

	uint32_t sssr = SSSR_ROR | SSSR_TUR | SSSR_BCE;
@@ -165,7 +165,7 @@ static int pxa_ssp_resume(struct snd_soc_dai *cpu_dai) 
	__raw_writel(priv->to,  ssp->mmio_base + SSTO);

	__raw_writel(priv->psp, ssp->mmio_base + SSPSP);



	if (cpu_dai->active)

	if (component->active)

		pxa_ssp_enable(ssp);

	else

		clk_disable_unprepare(ssp->clk);
@@ -850,8 +850,6 @@ static const struct snd_soc_dai_ops pxa_ssp_dai_ops = { 
static struct snd_soc_dai_driver pxa_ssp_dai = {

		.probe = pxa_ssp_probe,

		.remove = pxa_ssp_remove,

		.suspend = pxa_ssp_suspend,

		.resume = pxa_ssp_resume,

		.playback = {

			.channels_min = 1,

			.channels_max = 8,
@@ -879,6 +877,8 @@ static const struct snd_soc_component_driver pxa_ssp_component = { 
	.trigger	= pxa2xx_soc_pcm_trigger,

	.pointer	= pxa2xx_soc_pcm_pointer,

	.mmap		= pxa2xx_soc_pcm_mmap,

	.suspend	= pxa_ssp_suspend,

	.resume		= pxa_ssp_resume,

};



#ifdef CONFIG_OF

CRA Git | Maintained and supported by SUSTech CRA and CCSE