Commit 2c4d00cb authored Nov 09, 2020 by Andy Shevchenko

gpiolib: acpi: Use BIT() macro to increase readability



We may use BIT() macro to increase readability in
acpi_gpio_adr_space_handler().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

parent 74301f27

drivers/gpio/gpiolib-acpi.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1101,8 +1101,7 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,
		mutex_unlock(&achip->conn_lock);

		if (function == ACPI_WRITE)
		gpiod_set_raw_value_cansleep(desc,
		!!((1 << i) & *value));
		gpiod_set_raw_value_cansleep(desc, !!(*value & BIT(i)));
		else
		*value \|= (u64)gpiod_get_raw_value_cansleep(desc) << i;
		}

Admin message