Commit 2c4579e4 authored by David Howells's avatar David Howells
Browse files

rxrpc: Move usage count getting into rxrpc_queue_conn() 



Rather than calling rxrpc_get_connection() manually before calling
rxrpc_queue_conn(), do it inside the queue wrapper.

This allows us to do some important fixes:

 (1) If the usage count is 0, do nothing.  This prevents connections from
     being reanimated once they're dead.

 (2) If rxrpc_queue_work() fails because the work item is already queued,
     retract the usage count increment which would otherwise be lost.

 (3) Don't take a ref on the connection in the work function.  By passing
     the ref through the work item, this is unnecessary.  Doing it in the
     work function is too late anyway.  Previously, connection-directed
     packets held a ref on the connection, but that's not really the best
     idea.

And another useful changes:

 (*) Don't need to take a refcount on the connection in the data_ready
     handler unless we invoke the connection's work item.  We're using RCU
     there so that's otherwise redundant.

Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
parent eb9b9d22

net/rxrpc/ar-internal.h

+8 −1
Original line number Diff line number Diff line
@@ -584,10 +584,17 @@ static inline void rxrpc_get_connection(struct rxrpc_connection *conn) 
	atomic_inc(&conn->usage);

}



static inline

struct rxrpc_connection *rxrpc_get_connection_maybe(struct rxrpc_connection *conn)

{

	return atomic_inc_not_zero(&conn->usage) ? conn : NULL;

}



static inline void rxrpc_queue_conn(struct rxrpc_connection *conn)

{

	rxrpc_queue_work(&conn->processor);

	if (rxrpc_get_connection_maybe(conn) &&

	    !rxrpc_queue_work(&conn->processor))

		rxrpc_put_connection(conn);

}



/*

net/rxrpc/call_accept.c

+0 −1
Original line number Diff line number Diff line
@@ -132,7 +132,6 @@ static int rxrpc_accept_incoming_call(struct rxrpc_local *local, 
			_debug("await conn sec");

			list_add_tail(&call->accept_link, &rx->secureq);

			call->conn->state = RXRPC_CONN_SERVICE_CHALLENGING;

			rxrpc_get_connection(call->conn);

			set_bit(RXRPC_CONN_EV_CHALLENGE, &call->conn->events);

			rxrpc_queue_conn(call->conn);

		} else {

net/rxrpc/conn_event.c

+1 −7
Original line number Diff line number Diff line
@@ -266,12 +266,8 @@ void rxrpc_process_connection(struct work_struct *work) 


	_enter("{%d}", conn->debug_id);



	rxrpc_get_connection(conn);



	if (test_and_clear_bit(RXRPC_CONN_EV_CHALLENGE, &conn->events)) {

	if (test_and_clear_bit(RXRPC_CONN_EV_CHALLENGE, &conn->events))

		rxrpc_secure_connection(conn);

		rxrpc_put_connection(conn);

	}



	/* go through the conn-level event packets, releasing the ref on this

	 * connection that each one has when we've finished with it */
@@ -286,7 +282,6 @@ void rxrpc_process_connection(struct work_struct *work) 
			goto requeue_and_leave;

		case -ECONNABORTED:

		default:

			rxrpc_put_connection(conn);

			rxrpc_free_skb(skb);

			break;

		}
@@ -304,7 +299,6 @@ requeue_and_leave: 
protocol_error:

	if (rxrpc_abort_connection(conn, -ret, abort_code) < 0)

		goto requeue_and_leave;

	rxrpc_put_connection(conn);

	rxrpc_free_skb(skb);

	_leave(" [EPROTO]");

	goto out;

net/rxrpc/input.c

+0 −1
Original line number Diff line number Diff line
@@ -580,7 +580,6 @@ static void rxrpc_post_packet_to_conn(struct rxrpc_connection *conn, 
{

	_enter("%p,%p", conn, skb);



	rxrpc_get_connection(conn);

	skb_queue_tail(&conn->rx_queue, skb);

	rxrpc_queue_conn(conn);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE