Commit 2c41cc0b authored May 06, 2019 by Wen Yang Committed by Mauro Carvalho Chehab May 24, 2019

media: venus: firmware: fix leaked of_node references

The call to of_parse_phandle returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
drivers/media/platform/qcom/venus/firmware.c:90:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 82, but without a corresponding object release within this function.
drivers/media/platform/qcom/venus/firmware.c:94:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 82, but without a corresponding object release within this function.
drivers/media/platform/qcom/venus/firmware.c:128:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 82, but without a corresponding object release within this function.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent 4a96f5e1

drivers/media/platform/qcom/venus/firmware.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -87,11 +87,11 @@ static int venus_load_fw(struct venus_core core, const char fwname,

		ret = of_address_to_resource(node, 0, &r);
		if (ret)
		return ret;
		goto err_put_node;

		ret = request_firmware(&mdt, fwname, dev);
		if (ret < 0)
		return ret;
		goto err_put_node;

		fw_size = qcom_mdt_get_size(mdt);
		if (fw_size < 0) {
		@@ -125,6 +125,8 @@ static int venus_load_fw(struct venus_core core, const char fwname,
		memunmap(mem_va);
		err_release_fw:
		release_firmware(mdt);
		err_put_node:
		of_node_put(node);
		return ret;
		}

Admin message