Commit 2c3fd4c9 authored by Phil Edworthy's avatar Phil Edworthy Committed by Bjorn Helgaas
Browse files

PCI: rcar: Use correct initial HW settings 



Although the R-Car PCIe driver works as it is, there are a number of
incorrect settings that this patch corrects. It corrects:
 - enabling the PCI Express Extended Cap ID.
 - setting Data Link Layer Link Active Reporting Capable.
 - terminating list of capabilities.

It also removes enabling the MAC data scrambling as this is the default HW
setting, and removes incorrect code to enable slave bus mastering as this
is done by the PCI core.

Signed-off-by: default avatarPhil Edworthy <phil.edworthy@renesas.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarSimon Horman <horms+renesas@verge.net.au>
parent 8eb12c3b

drivers/pci/host/pcie-rcar.c

+4 −11
Original line number Diff line number Diff line
@@ -481,14 +481,15 @@ static int rcar_pcie_hw_init(struct rcar_pcie *pcie) 
	rcar_rmw32(pcie, RCONF(PCI_SUBORDINATE_BUS), 0xff, 1);



	/* Initialize default capabilities. */

	rcar_rmw32(pcie, REXPCAP(0), 0, PCI_CAP_ID_EXP);

	rcar_rmw32(pcie, REXPCAP(0), 0xff, PCI_CAP_ID_EXP);

	rcar_rmw32(pcie, REXPCAP(PCI_EXP_FLAGS),

		PCI_EXP_FLAGS_TYPE, PCI_EXP_TYPE_ROOT_PORT << 4);

	rcar_rmw32(pcie, RCONF(PCI_HEADER_TYPE), 0x7f,

		PCI_HEADER_TYPE_BRIDGE);



	/* Enable data link layer active state reporting */

	rcar_rmw32(pcie, REXPCAP(PCI_EXP_LNKCAP), 0, PCI_EXP_LNKCAP_DLLLARC);

	rcar_rmw32(pcie, REXPCAP(PCI_EXP_LNKCAP), PCI_EXP_LNKCAP_DLLLARC,

		PCI_EXP_LNKCAP_DLLLARC);



	/* Write out the physical slot number = 0 */

	rcar_rmw32(pcie, REXPCAP(PCI_EXP_SLTCAP), PCI_EXP_SLTCAP_PSN, 0);
@@ -497,10 +498,7 @@ static int rcar_pcie_hw_init(struct rcar_pcie *pcie) 
	rcar_rmw32(pcie, TLCTLR+1, 0x3f, 50);



	/* Terminate list of capabilities (Next Capability Offset=0) */

	rcar_rmw32(pcie, RVCCAP(0), 0xfff0, 0);



	/* Enable MAC data scrambling. */

	rcar_rmw32(pcie, MACCTLR, SCRAMBLE_DISABLE, 0);

	rcar_rmw32(pcie, RVCCAP(0), 0xfff00000, 0);



	/* Enable MSI */

	if (IS_ENABLED(CONFIG_PCI_MSI))
@@ -517,11 +515,6 @@ static int rcar_pcie_hw_init(struct rcar_pcie *pcie) 
	/* Enable INTx interrupts */

	rcar_rmw32(pcie, PCIEINTXR, 0, 0xF << 8);



	/* Enable slave Bus Mastering */

	rcar_rmw32(pcie, RCONF(PCI_STATUS), PCI_STATUS_DEVSEL_MASK,

		PCI_COMMAND_IO | PCI_COMMAND_MEMORY | PCI_COMMAND_MASTER |

		PCI_STATUS_CAP_LIST | PCI_STATUS_DEVSEL_FAST);



	wmb();



	return 0;

CRA Git | Maintained and supported by SUSTech CRA and CCSE