Commit 2c3e0262 authored Jun 23, 2006 by Roman Zippel Committed by Linus Torvalds Jun 23, 2006

[PATCH] m68k: completely initialize hw_regs_t in ide_setup_ports

ide_setup_ports does not completely initialize the hw_regs_t structure which
can cause random failures, as the structure is often on the stack.  None of
the callers expect a partially initialized structure, i.e.  none of them do
any setup of their own before calling ide_setup_ports().

Signed-off-by: Roman Zippel <zippel@linux-m68k.org>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent daacf8bc

drivers/ide/ide.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -726,6 +726,7 @@ void ide_setup_ports ( hw_regs_t *hw,
		{
		int i;

		memset(hw, 0, sizeof(hw_regs_t));
		for (i = 0; i < IDE_NR_PORTS; i++) {
		if (offsets[i] == -1) {
		switch(i) {

drivers/ide/legacy/q40ide.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -80,6 +80,7 @@ void q40_ide_setup_ports ( hw_regs_t *hw,
		{
		int i;

		memset(hw, 0, sizeof(hw_regs_t));
		for (i = 0; i < IDE_NR_PORTS; i++) {
		/* BIG FAT WARNING:
		assumption: only DATA port is ever used in 16 bit mode */

Admin message