Commit 2c37e084 authored Oct 04, 2017 by Ulf Magnusson Committed by Masahiro Yamada Dec 07, 2017

kconfig: Warn if choice default is not in choice

This will catch mistakes like in the following real-world example, where
a "CONFIG_" prefix snuck in, making an undefined symbol the default:

	choice
		prompt "Compiler optimization level"
		default CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE

	config CC_OPTIMIZE_FOR_PERFORMANCE
		...

	config CC_OPTIMIZE_FOR_SIZE
		...

	endchoice

This now prints the following warning:

	init/Kconfig:1036:warning: choice default symbol 'CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE' is not contained in the choice

Cases where the default symbol belongs to the wrong choice are also
detected.

(The mistake is harmless here: Since the default symbol is not visible,
the choice falls back on using the first visible symbol as the default,
which is CC_OPTIMIZE_FOR_PERFORMANCE, as intended.)

Discovered while playing around with Kconfiglib
(https://github.com/ulfalizer/Kconfiglib

).

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

parent ae64f9bd

scripts/kconfig/menu.c

+10 −0

Original line number	Diff line number	Diff line
		@@ -252,6 +252,16 @@ static void sym_check_prop(struct symbol *sym)
		"'%s': number is invalid",
		sym->name);
		}
		if (sym_is_choice(sym)) {
		struct property *choice_prop =
		sym_get_choice_prop(sym2);

		if (!choice_prop \|\|
		prop_get_symbol(choice_prop) != sym)
		prop_warn(prop,
		"choice default symbol '%s' is not contained in the choice",
		sym2->name);
		}
		break;
		case P_SELECT:
		case P_IMPLY:

Admin message