mm: Clear arch specific VM flags on protection change (2c2d57b5) · Commits · 戴 / test

When protection bits are changed on a VMA, some of the architecture specific flags should be cleared as well. An examples of this are the PKEY flags on x86. This patch expands the current code that clears PKEY flags for x86, to support similar functionality for other architectures as well. Signed-off-by:

Khalid Aziz <khalid.aziz@oracle.com> Cc: Khalid Aziz <khalid@gonehiking.org> Reviewed-by:

Anthony Yznaga <anthony.yznaga@oracle.com> Acked-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

David S. Miller <davem@davemloft.net>

include/linux/mm.h

+6 −0

Original line number	Diff line number	Diff line
		@@ -287,6 +287,12 @@ extern unsigned int kobjsize(const void *objp);
		/* This mask is used to clear all the VMA flags used by mlock */
		#define VM_LOCKED_CLEAR_MASK (~(VM_LOCKED \| VM_LOCKONFAULT))

		/* Arch-specific flags to clear when updating VM flags on protection change */
		#ifndef VM_ARCH_CLEAR
		# define VM_ARCH_CLEAR VM_NONE
		#endif
		#define VM_FLAGS_CLEAR (ARCH_VM_PKEY_FLAGS \| VM_ARCH_CLEAR)

		/*
		* mapping from the currently active vm_flags protection bits (the
		* low four bits) to a page protection mask..

mm/mprotect.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -475,7 +475,7 @@ static int do_mprotect_pkey(unsigned long start, size_t len,
		* cleared from the VMA.
		*/
		mask_off_old_flags = VM_READ \| VM_WRITE \| VM_EXEC \|
		ARCH_VM_PKEY_FLAGS;
		VM_FLAGS_CLEAR;

		new_vma_pkey = arch_override_mprotect_pkey(vma, prot, pkey);
		newflags = calc_vm_prot_bits(prot, new_vma_pkey);

Admin message