Commit 2c1497bb authored May 08, 2017 by Ilan Tayari Committed by Steffen Klassert May 08, 2017

xfrm: Fix NETDEV_DOWN with IPSec offload



Upon NETDEV_DOWN event, all xfrm_state objects which are bound to
the device are flushed.

The condition for this is wrong, though, testing dev->hw_features
instead of dev->features. If a device has non-user-modifiable
NETIF_F_HW_ESP, then its xfrm_state objects are not flushed,
causing a crash later on after the device is deleted.

Check dev->features instead of dev->hw_features.

Fixes: d77e38e6 ("xfrm: Add an IPsec hardware offloading API")
Signed-off-by: Ilan Tayari <ilant@mellanox.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>

parent d90c9024

net/xfrm/xfrm_device.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -170,7 +170,7 @@ static int xfrm_dev_feat_change(struct net_device *dev)

		static int xfrm_dev_down(struct net_device *dev)
		{
		if (dev->hw_features & NETIF_F_HW_ESP)
		if (dev->features & NETIF_F_HW_ESP)
		xfrm_dev_state_flush(dev_net(dev), dev, true);

		xfrm_garbage_collect(dev_net(dev));

Admin message