Commit 2c11dba0 authored Nov 06, 2017 by Frederic Weisbecker Committed by Ingo Molnar Nov 08, 2017

sched/clock, sched/cputime: Use lockdep to assert IRQs are disabled/enabled

Use lockdep to check that IRQs are enabled or disabled as expected. This
way the sanity check only shows overhead when concurrency correctness
debug code is enabled.

Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Cc: David S . Miller <davem@davemloft.net>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Tejun Heo <tj@kernel.org>
Link: http://lkml.kernel.org/r/1509980490-4285-12-git-send-email-frederic@kernel.org

Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 3c7169a3

kernel/sched/clock.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -388,7 +388,7 @@ void sched_clock_tick(void)
		if (unlikely(!sched_clock_running))
		return;

		WARN_ON_ONCE(!irqs_disabled());
		lockdep_assert_irqs_disabled();

		scd = this_scd();
		__scd_stamp(scd);

kernel/sched/cputime.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -259,8 +259,7 @@ static inline u64 account_other_time(u64 max)
		{
		u64 accounted;

		/* Shall be converted to a lockdep-enabled lightweight check */
		WARN_ON_ONCE(!irqs_disabled());
		lockdep_assert_irqs_disabled();

		accounted = steal_account_process_time(max);

Admin message