Commit 2c0d259e authored Jun 04, 2014 by James Hogan Committed by Linus Torvalds Jun 04, 2014

compiler.h: avoid sparse errors in __compiletime_error_fallback()



Usually, BUG_ON and friends aren't even evaluated in sparse, but recently
compiletime_assert_atomic_type() was added, and that now results in a
sparse warning every time it is used.

The reason turns out to be the temporary variable, after it sparse no
longer considers the value to be a constant, and results in a warning and
an error.  The error is the more annoying part of this as it suppresses
any further warnings in the same file, hiding other problems.

Unfortunately the condition cannot be simply expanded out to avoid the
temporary variable since it breaks compiletime_assert on old versions of
GCC such as GCC 4.2.4 which the latest metag compiler is based on.

Therefore #ifndef __CHECKER__ out the __compiletime_error_fallback which
uses the potentially negative size array to trigger a conditional compiler
error, so that sparse doesn't see it.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Johannes Berg <johannes.berg@intel.com>
Cc: Daniel Santos <daniel.santos@pobox.com>
Cc: Luciano Coelho <luciano.coelho@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 00f01791

include/linux/compiler.h

+11 −2

Original line number	Diff line number	Diff line
		@@ -323,9 +323,18 @@ void ftrace_likely_update(struct ftrace_branch_data *f, int val, int expect);
		#endif
		#ifndef __compiletime_error
		# define __compiletime_error(message)
		/*
		* Sparse complains of variable sized arrays due to the temporary variable in
		* __compiletime_assert. Unfortunately we can't just expand it out to make
		* sparse see a constant array size without breaking compiletime_assert on old
		* versions of GCC (e.g. 4.2.4), so hide the array from sparse altogether.
		*/
		# ifndef __CHECKER__
		# define __compiletime_error_fallback(condition) \
		do { ((void)sizeof(char[1 - 2 * condition])); } while (0)
		#else
		# endif
		#endif
		#ifndef __compiletime_error_fallback
		# define __compiletime_error_fallback(condition) do { } while (0)
		#endif

Admin message