Commit 2bdd163c authored Jul 13, 2015 by Jason Gerecke Committed by Jiri Kosina Jul 17, 2015

HID: wacom: Set default device name to value from wacom->features



Allocated input devices should not use the 'pen_name' by default since
we do not know at that point in time if that is an appropriate choice
of name. Instead, use the (tool-agnostic) name that is stored in the
device's 'wacom_features' structure. This also has the nice side-effect
of requring us to be explicit about the naming of the pen device, as
we already are for touch and pad devices.

Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>

parent d9f2d203

drivers/hid/wacom_sys.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1130,7 +1130,7 @@ static struct input_dev wacom_allocate_input(struct wacom wacom)
		if (!input_dev)
		return NULL;

		input_dev->name = wacom_wac->pen_name;
		input_dev->name = wacom_wac->features.name;
		input_dev->phys = hdev->phys;
		input_dev->dev.parent = &hdev->dev;
		input_dev->open = wacom_open;
		@@ -1183,6 +1183,7 @@ static int wacom_allocate_inputs(struct wacom *wacom)
		return -ENOMEM;
		}

		wacom_wac->pen_input->name = wacom_wac->pen_name;
		wacom_wac->touch_input->name = wacom_wac->touch_name;
		wacom_wac->pad_input->name = wacom_wac->pad_name;

Admin message