Commit 2bcdacb7 authored Sep 04, 2019 by Roderick Colenbrander Committed by Jiri Kosina Sep 05, 2019

HID: sony: Fix memory corruption issue on cleanup.



The sony driver is not properly cleaning up from potential failures in
sony_input_configured. Currently it calls hid_hw_stop, while hid_connect
is still running. This is not a good idea, instead hid_hw_stop should
be moved to sony_probe. Similar changes were recently made to Logitech
drivers, which were also doing improper cleanup.

Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
CC: stable@vger.kernel.org
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent b20bef4b

drivers/hid/hid-sony.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2811,7 +2811,6 @@ err_stop:
		sony_cancel_work_sync(sc);
		sony_remove_dev_list(sc);
		sony_release_device_id(sc);
		hid_hw_stop(hdev);
		return ret;
		}

		@@ -2876,6 +2875,7 @@ static int sony_probe(struct hid_device hdev, const struct hid_device_id id)
		*/
		if (!(hdev->claimed & HID_CLAIMED_INPUT)) {
		hid_err(hdev, "failed to claim input\n");
		hid_hw_stop(hdev);
		return -ENODEV;
		}

Admin message