Unverified Commit 2bb8ede0 authored Dec 06, 2018 by Linus Walleij Committed by Mark Brown Dec 11, 2018

regulator: lp8788-ldo: Let core handle GPIO descriptor



Use the gpiod_get() rather than the devm_* version so that the
regulator core can handle the lifecycle of these descriptors.

Fixes: 2468f0d5 ("regulator: lp8788-ldo: Pass descriptor instead of GPIO number")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent e8a33aa0

drivers/regulator/lp8788-ldo.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -501,8 +501,12 @@ static int lp8788_config_ldo_enable_mode(struct platform_device *pdev,
		return 0;
		}

		/* FIXME: check default mode for GPIO here: high or low? */
		ldo->ena_gpiod = devm_gpiod_get_index_optional(&pdev->dev,
		/*
		* Do not use devm* here: the regulator core takes over the
		* lifecycle management of the GPIO descriptor.
		* FIXME: check default mode for GPIO here: high or low?
		*/
		ldo->ena_gpiod = gpiod_get_index_optional(&pdev->dev,
		"enable",
		enable_id,
		GPIOD_OUT_HIGH \|

Admin message