staging: lustre: use memdup_user to allocate memory and copy from user (2baddf26) · Commits · 戴 / test

Replace a call to kmalloc and a call to copy_from_user with a call to memdup_user to simplify the code. Issue found with coccicheck. Signed-off-by:

drivers/staging/lustre/lnet/selftest/conctl.c

+4 −6

Original line number	Diff line number	Diff line
		@@ -648,12 +648,10 @@ static int lst_test_add_ioctl(struct lstio_test_args *args)
		return -EINVAL;

		if (args->lstio_tes_param) {
		param = kmalloc(args->lstio_tes_param_len, GFP_KERNEL);
		if (!param)
		goto out;
		if (copy_from_user(param, args->lstio_tes_param,
		args->lstio_tes_param_len)) {
		rc = -EFAULT;
		param = memdup_user(args->lstio_tes_param,
		args->lstio_tes_param_len);
		if (IS_ERR(param)) {
		rc = PTR_ERR(param);
		goto out;
		}
		}