Commit 2ba835dd authored by Aishwarya Pant's avatar Aishwarya Pant Committed by Greg Kroah-Hartman
Browse files

staging: bcm2835-camera: remove anonymous field declarations 



Anonymous field declarations are error prone. This patch replaces
anonymous declarations with explicit field declarations for typedef
SERVICE_CREATION_T in vchiq_mmal_init(..)

Signed-off-by: default avatarAishwarya Pant <aishpant@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7ebe438c

drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c

+10 −10
Original line number Diff line number Diff line
@@ -1977,16 +1977,16 @@ int vchiq_mmal_init(struct vchiq_mmal_instance **out_instance) 
	static VCHI_CONNECTION_T *vchi_connection;

	static VCHI_INSTANCE_T vchi_instance;

	SERVICE_CREATION_T params = {

		VCHI_VERSION_EX(VC_MMAL_VER, VC_MMAL_MIN_VER),

		VC_MMAL_SERVER_NAME,

		vchi_connection,

		0,		/* rx fifo size (unused) */

		0,		/* tx fifo size (unused) */

		service_callback,

		NULL,		/* service callback parameter */

		1,		/* unaligned bulk receives */

		1,		/* unaligned bulk transmits */

		0		/* want crc check on bulk transfers */

		.version		= VCHI_VERSION_EX(VC_MMAL_VER, VC_MMAL_MIN_VER),

		.service_id		= VC_MMAL_SERVER_NAME,

		.connection		= vchi_connection,

		.rx_fifo_size		= 0,

		.tx_fifo_size		= 0,

		.callback		= service_callback,

		.callback_param		= NULL,

		.want_unaligned_bulk_rx = 1,

		.want_unaligned_bulk_tx = 1,

		.want_crc		= 0

	};



	/* compile time checks to ensure structure size as they are

CRA Git | Maintained and supported by SUSTech CRA and CCSE