Commit 2ba436fc authored Jan 20, 2014 by Pablo Neira Ayuso

netfilter: xt_ipcomp: Use ntohs to ease sparse warning



0-DAY kernel build testing backend reported:

sparse warnings: (new ones prefixed by >>)

 >> >> net/netfilter/xt_ipcomp.c:63:26: sparse: restricted __be16 degrades to integer
 >> >> net/netfilter/xt_ipcomp.c:63:26: sparse: cast to restricted __be32

Fix this by using ntohs without shifting.

Tested with: make C=1 CF=-D__CHECK_ENDIAN__

Signed-off-by: Fan Du <fan.du@windriver.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent 3d0a0620

net/netfilter/xt_ipcomp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -60,7 +60,7 @@ static bool comp_mt(const struct sk_buff skb, struct xt_action_param par)
		}

		return spi_match(compinfo->spis[0], compinfo->spis[1],
		ntohl(chdr->cpi << 16),
		ntohs(chdr->cpi),
		!!(compinfo->invflags & XT_IPCOMP_INV_SPI));
		}

Admin message