Commit 2ba31cd9 authored Feb 07, 2020 by Verma, Aashish Committed by David S. Miller Feb 07, 2020

net: stmmac: fix missing IFF_MULTICAST check in dwmac4_set_filter



Without checking for IFF_MULTICAST flag, it is wrong to assume multicast
filtering is always enabled. By checking against IFF_MULTICAST, now
the driver behaves correctly when the multicast support is toggled by below
command:-
  ip link set <devname> multicast off|on

Fixes: 477286b5 ("stmmac: add GMAC4 core support")
Signed-off-by: Verma, Aashish <aashishx.verma@intel.com>
Tested-by: Tan, Tee Min <tee.min.tan@intel.com>
Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 907a0768

drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -420,7 +420,7 @@ static void dwmac4_set_filter(struct mac_device_info *hw,
		value \|= GMAC_PACKET_FILTER_PM;
		/* Set all the bits of the HASH tab */
		memset(mc_filter, 0xff, sizeof(mc_filter));
		} else if (!netdev_mc_empty(dev)) {
		} else if (!netdev_mc_empty(dev) && (dev->flags & IFF_MULTICAST)) {
		struct netdev_hw_addr *ha;

		/* Hash filter for multicast */

Admin message