Commit 2b892649 authored May 28, 2019 by Max Uvarov Committed by David S. Miller May 29, 2019

net: phy: dp83867: Set up RGMII TX delay



PHY_INTERFACE_MODE_RGMII_RXID is less then TXID
so code to set tx delay is never called.

Fixes: 2a10154a ("net: phy: dp83867: Add TI dp83867 phy")
Signed-off-by: Max Uvarov <muvarov@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c8081fc3

drivers/net/phy/dp83867.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -255,10 +255,8 @@ static int dp83867_config_init(struct phy_device *phydev)
		ret = phy_write(phydev, MII_DP83867_PHYCTRL, val);
		if (ret)
		return ret;
		}

		if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) &&
		(phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) {
		/* Set up RGMII delays */
		val = phy_read_mmd(phydev, DP83867_DEVADDR, DP83867_RGMIICTL);

		if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)

Admin message