Commit 2b69c828 authored by Jeff Layton's avatar Jeff Layton
Browse files

mm: drop "wait" parameter from write_one_page() 

The callers all set it to 1.

Also, make it clear that this function will not set any sort of AS_*
error, and that the caller must do so if necessary.  No existing caller
uses this on normal files, so none of them need it.

Also, add __must_check here since, in general, the callers need to handle
an error here in some fashion.

Link: http://lkml.kernel.org/r/20170525103303.6524-1-jlayton@redhat.com


Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
Reviewed-by: default avatarRoss Zwisler <ross.zwisler@linux.intel.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Reviewed-by: default avatarMatthew Wilcox <mawilcox@microsoft.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent c86daad2

fs/exofs/dir.c

+1 −1
Original line number Diff line number Diff line
@@ -72,7 +72,7 @@ static int exofs_commit_chunk(struct page *page, loff_t pos, unsigned len) 
	set_page_dirty(page);



	if (IS_DIRSYNC(dir))

		err = write_one_page(page, 1);

		err = write_one_page(page);

	else

		unlock_page(page);

fs/ext2/dir.c

+1 −1
Original line number Diff line number Diff line
@@ -100,7 +100,7 @@ static int ext2_commit_chunk(struct page *page, loff_t pos, unsigned len) 
	}



	if (IS_DIRSYNC(dir)) {

		err = write_one_page(page, 1);

		err = write_one_page(page);

		if (!err)

			err = sync_inode_metadata(dir, 1);

	} else {

fs/jfs/jfs_metapage.c

+2 −2
Original line number Diff line number Diff line
@@ -711,7 +711,7 @@ void force_metapage(struct metapage *mp) 
	get_page(page);

	lock_page(page);

	set_page_dirty(page);

	write_one_page(page, 1);

	write_one_page(page);

	clear_bit(META_forcewrite, &mp->flag);

	put_page(page);

}
@@ -756,7 +756,7 @@ void release_metapage(struct metapage * mp) 
		set_page_dirty(page);

		if (test_bit(META_sync, &mp->flag)) {

			clear_bit(META_sync, &mp->flag);

			write_one_page(page, 1);

			write_one_page(page);

			lock_page(page); /* write_one_page unlocks the page */

		}

	} else if (mp->lsn)	/* discard_metapage doesn't remove it */

fs/minix/dir.c

+1 −1
Original line number Diff line number Diff line
@@ -57,7 +57,7 @@ static int dir_commit_chunk(struct page *page, loff_t pos, unsigned len) 
		mark_inode_dirty(dir);

	}

	if (IS_DIRSYNC(dir))

		err = write_one_page(page, 1);

		err = write_one_page(page);

	else

		unlock_page(page);

	return err;

fs/sysv/dir.c

+1 −1
Original line number Diff line number Diff line
@@ -45,7 +45,7 @@ static int dir_commit_chunk(struct page *page, loff_t pos, unsigned len) 
		mark_inode_dirty(dir);

	}

	if (IS_DIRSYNC(dir))

		err = write_one_page(page, 1);

		err = write_one_page(page);

	else

		unlock_page(page);

	return err;

CRA Git | Maintained and supported by SUSTech CRA and CCSE