Commit 2b6022a3 authored Apr 19, 2020 by Hans de Goede Committed by Rafael J. Wysocki Apr 20, 2020

ACPI: button: Drop no longer necessary Asus T200TA lid_init_state quirk



Commit 17e5888e ("x86: Select HARDIRQS_SW_RESEND on x86") fixes
the edge-triggered embedded-controller (WC) IRQ not being replayed after
resume when woken by opening the lid, which gets signaled by the EC.

This means that the lid_init_state=ACPI_BUTTON_LID_INIT_OPEN quirk for
the Asus T200TA is no longer necessary, the lid now works properly
without it, so drop the quirk.

Fixes: 17e5888e ("x86: Select HARDIRQS_SW_RESEND on x86")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent ae83d0b4

drivers/acpi/button.c

+0 −12

Original line number	Diff line number	Diff line
		@@ -87,18 +87,6 @@ static const struct dmi_system_id dmi_lid_quirks[] = {
		},
		.driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_DISABLED,
		},
		{
		/*
		* Asus T200TA, _LID keeps reporting closed after every second
		* openening of the lid. Causing immediate re-suspend after
		* opening every other open. Using LID_INIT_OPEN fixes this.
		*/
		.matches = {
		DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
		DMI_MATCH(DMI_PRODUCT_NAME, "T200TA"),
		},
		.driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN,
		},
		{
		/* GP-electronic T701, _LID method points to a floating GPIO */
		.matches = {

Admin message