drm/fb-helper: Return early in damage worker (2b5f31aa) · Commits · 戴 / test

Returning early in the damage worker if no update is required. Makes the code more readable. No functional changes are being made. v3: * s/dirty/damage in commit message (Sam) Signed-off-by:

Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by:

Sam Ravnborg <sam@ravnborg.org> Acked-by:

Maxime Ripard <mripard@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20201120102545.4047-6-tzimmermann@suse.de

drivers/gpu/drm/drm_fb_helper.c

+15 −16

Original line number	Diff line number	Diff line
		@@ -407,8 +407,9 @@ static void drm_fb_helper_damage_work(struct work_struct *work)
		clip->x2 = clip->y2 = 0;
		spin_unlock_irqrestore(&helper->damage_lock, flags);

		/* call dirty callback only when it has been really touched */
		if (clip_copy.x1 < clip_copy.x2 && clip_copy.y1 < clip_copy.y2) {
		/* Call damage handlers only if necessary */
		if (!(clip_copy.x1 < clip_copy.x2 && clip_copy.y1 < clip_copy.y2))
		return;

		/* Generic fbdev uses a shadow buffer */
		if (helper->buffer) {
		@@ -419,13 +420,11 @@ static void drm_fb_helper_damage_work(struct work_struct *work)
		}

		if (helper->fb->funcs->dirty)
		helper->fb->funcs->dirty(helper->fb, NULL, 0, 0,
		&clip_copy, 1);
		helper->fb->funcs->dirty(helper->fb, NULL, 0, 0, &clip_copy, 1);

		if (helper->buffer)
		drm_client_buffer_vunmap(helper->buffer);
		}
		}

		/**
		* drm_fb_helper_prepare - setup a drm_fb_helper structure

Admin message