Commit 2b481835 authored by Dan Carpenter's avatar Dan Carpenter Committed by Kalle Valo
Browse files

wil6210: use after free in wil_netif_rx_any() 



The debug code dereferences "skb" to print "skb->len" so we have to
print the message before we free "skb".

Fixes: f99fe49f ("wil6210: add wil_netif_rx() helper function")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent fddbfeec

drivers/net/wireless/ath/wil6210/txrx.c

+1 −1
Original line number Diff line number Diff line
@@ -1012,11 +1012,11 @@ void wil_netif_rx_any(struct sk_buff *skb, struct net_device *ndev) 
	skb_orphan(skb);



	if (security && (wil->txrx_ops.rx_crypto_check(wil, skb) != 0)) {

		wil_dbg_txrx(wil, "Rx drop %d bytes\n", skb->len);

		dev_kfree_skb(skb);

		ndev->stats.rx_dropped++;

		stats->rx_replay++;

		stats->rx_dropped++;

		wil_dbg_txrx(wil, "Rx drop %d bytes\n", skb->len);

		return;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE