Commit 2b3957c3 authored Feb 27, 2018 by Xin Long Committed by David S. Miller Feb 27, 2018

sit: fix IFLA_MTU ignored on NEWLINK



Commit 128bb975 ("ip6_gre: init dev->mtu and dev->hard_header_len
correctly") fixed IFLA_MTU ignored on NEWLINK for ip6_gre. The same
mtu fix is also needed for sit.

Note that dev->hard_header_len setting for sit works fine, no need to
fix it. sit is actually ipv4 tunnel, it can't call ip6_tnl_change_mtu
to set mtu.

Reported-by: Jianlin Shi <jishi@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a6aa8044

net/ipv6/sit.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -1578,6 +1578,13 @@ static int ipip6_newlink(struct net src_net, struct net_device dev,
		if (err < 0)
		return err;

		if (tb[IFLA_MTU]) {
		u32 mtu = nla_get_u32(tb[IFLA_MTU]);

		if (mtu >= IPV6_MIN_MTU && mtu <= 0xFFF8 - dev->hard_header_len)
		dev->mtu = mtu;
		}

		#ifdef CONFIG_IPV6_SIT_6RD
		if (ipip6_netlink_6rd_parms(data, &ip6rd))
		err = ipip6_tunnel_update_6rd(nt, &ip6rd);

Admin message