Unverified Commit 2b2d5c4d authored Feb 07, 2020 by Dragos Tarcatu Committed by Mark Brown Feb 19, 2020

ASoC: topology: Fix memleak in soc_tplg_link_elems_load()



If soc_tplg_link_config() fails, _link needs to be freed in case of
topology ABI version mismatch. However the current code is returning
directly and ends up leaking memory in this case.
This patch fixes that.

Fixes: 593d9e52 ("ASoC: topology: Add support to configure existing physical DAI links")
Signed-off-by: Dragos Tarcatu <dragos_tarcatu@mentor.com>
Link: https://lore.kernel.org/r/20200207185325.22320-2-dragos_tarcatu@mentor.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 6c89ffea

sound/soc/soc-topology.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -2376,8 +2376,11 @@ static int soc_tplg_link_elems_load(struct soc_tplg *tplg,
		}

		ret = soc_tplg_link_config(tplg, _link);
		if (ret < 0)
		if (ret < 0) {
		if (!abi_match)
		kfree(_link);
		return ret;
		}

		/* offset by version-specific struct size and
		* real priv data size

Admin message