Commit 2b286b09 authored Jun 28, 2017 by Jerome Brunet Committed by Stephen Boyd Jun 29, 2017

clk: scpi: error when clock fails to register



Current implementation of scpi_clk_add just print a warning when clock
fails to register but then keep going as if nothing happened. The
provider is then registered with bogus data.

This may latter lead to an Oops in __clk_create_clk when
hlist_add_head(&clk->clks_node, &hw->core->clks) is called.

This patch fixes the issue and errors if a clock fails to register.

Fixes: cd52c2a4 ("clk: add support for clocks provided by SCP(System Control Processor)")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

parent b3b02eac

drivers/clk/clk-scpi.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -245,9 +245,11 @@ static int scpi_clk_add(struct device dev, struct device_node np,
		sclk->id = val;

		err = scpi_clk_ops_init(dev, match, sclk, name);
		if (err)
		if (err) {
		dev_err(dev, "failed to register clock '%s'\n", name);
		else
		return err;
		}

		dev_dbg(dev, "Registered clock '%s'\n", name);
		clk_data->clk[idx] = sclk;
		}

Admin message