Commit 2b1d3ae9 authored May 28, 2015 by Andrew Morton Committed by Linus Torvalds May 28, 2015

fs/binfmt_elf.c:load_elf_binary(): return -EINVAL on zero-length mappings



load_elf_binary() returns `retval', not `error'.

Fixes: a87938b2 ("fs/binfmt_elf.c: fix bug in loading of PIE binaries")
Reported-by: James Hogan <james.hogan@imgtec.com>
Cc: Michael Davidson <md@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 649b8de2

fs/binfmt_elf.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -918,7 +918,7 @@ static int load_elf_binary(struct linux_binprm *bprm)
		total_size = total_mapping_size(elf_phdata,
		loc->elf_ex.e_phnum);
		if (!total_size) {
		error = -EINVAL;
		retval = -EINVAL;
		goto out_free_dentry;
		}
		}

Admin message