drm/i915: Simplify LVDS crtc_mask setup (2b0b2741) · Commits · 戴 / test

We don't need to special case PCH vs. gen4 when setting up the LVDS crtc_mask. Just claim pipes A|B|C work and intel_encoder_possible_crtcs() will drop out any crtc that doesn't exist. v2: Put the special case first to match what most other encoders do Signed-off-by:

Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20191002162505.30716-2-ville.syrjala@linux.intel.com Reviewed-by:

Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

drivers/gpu/drm/i915/display/intel_lvds.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -899,12 +899,10 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)
		intel_encoder->power_domain = POWER_DOMAIN_PORT_OTHER;
		intel_encoder->port = PORT_NONE;
		intel_encoder->cloneable = 0;
		if (HAS_PCH_SPLIT(dev_priv))
		intel_encoder->crtc_mask = BIT(PIPE_A) \| BIT(PIPE_B) \| BIT(PIPE_C);
		else if (IS_GEN(dev_priv, 4))
		intel_encoder->crtc_mask = BIT(PIPE_A) \| BIT(PIPE_B);
		else
		if (INTEL_GEN(dev_priv) < 4)
		intel_encoder->crtc_mask = BIT(PIPE_B);
		else
		intel_encoder->crtc_mask = BIT(PIPE_A) \| BIT(PIPE_B) \| BIT(PIPE_C);

		drm_connector_helper_add(connector, &intel_lvds_connector_helper_funcs);
		connector->display_info.subpixel_order = SubPixelHorizontalRGB;

Admin message