Commit 2af5066f authored Jun 18, 2009 by Hidetoshi Seto Committed by Jesse Barnes Jun 19, 2009

PCI: make msi_free_irqs() to use msix_mask_irq() instead of open coded write



Use msix_mask_irq() instead of direct use of writel, so as not to clear
preserved bits in the Vector Control register [31:1].

Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

parent f598282f

drivers/pci/msi.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -653,10 +653,7 @@ static int msi_free_irqs(struct pci_dev* dev)

		list_for_each_entry_safe(entry, tmp, &dev->msi_list, list) {
		if (entry->msi_attrib.is_msix) {
		writel(1, entry->mask_base + entry->msi_attrib.entry_nr
		* PCI_MSIX_ENTRY_SIZE
		+ PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET);

		msix_mask_irq(entry, 1);
		if (list_is_last(&entry->list, &dev->msi_list))
		iounmap(entry->mask_base);
		}

Admin message