Commit 2aedcd09 authored Mar 03, 2016 by Masahiro Yamada Committed by Michal Marek Mar 04, 2016

kbuild: suppress annoying "... is up to date." message



Under certain conditions, Kbuild shows "... is up to date" where
if_changed or friends are used.

For example, the incremental build of ARM64 Linux shows this message
when the kernel image has not been updated.

  $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
    CHK     include/config/kernel.release
    CHK     include/generated/uapi/linux/version.h
    CHK     include/generated/utsrelease.h
    CHK     include/generated/bounds.h
    CHK     include/generated/timeconst.h
    CHK     include/generated/asm-offsets.h
    CALL    scripts/checksyscalls.sh
    CHK     include/generated/compile.h
    CHK     kernel/config_data.h
  make[1]: `arch/arm64/boot/Image.gz' is up to date.
    Building modules, stage 2.
    MODPOST 0 modules

The following is the build rule in arch/arm64/boot/Makefile:

  $(obj)/Image.gz: $(obj)/Image FORCE
          $(call if_changed,gzip)

If the Image.gz is newer than the Image and the command line has not
changed (i.e., $(any-prereq) and $(arg-check) are both empty), the
build rule $(call if_changed,gzip) is evaluated to be empty, then
GNU Make reports the target is up to date.  In order to make GNU Make
quiet, we need to give it something to do, for example, "@:".  This
should be fixed in the Kbuild core part rather than in each Makefile.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Michal Marek <mmarek@suse.com>

parent 46fe94ad

scripts/Kbuild.include

+3 −3

Original line number	Diff line number	Diff line
		@@ -251,7 +251,7 @@ any-prereq = $(filter-out $(PHONY),$?) $(filter-out $(PHONY) $(wildcard $^),$^)
		if_changed = $(if $(strip $(any-prereq) $(arg-check)), \
		@set -e; \
		$(echo-cmd) $(cmd_$(1)); \
		printf '%s\n' 'cmd_$@ := $(make-cmd)' > $(dot-target).cmd)
		printf '%s\n' 'cmd_$@ := $(make-cmd)' > $(dot-target).cmd, @:)

		# Execute the command and also postprocess generated .d dependencies file.
		if_changed_dep = $(if $(strip $(any-prereq) $(arg-check) ), \
		@@ -259,14 +259,14 @@ if_changed_dep = $(if $(strip $(any-prereq) $(arg-check) ), \
		$(echo-cmd) $(cmd_$(1)); \
		scripts/basic/fixdep $(depfile) $@ '$(make-cmd)' > $(dot-target).tmp;\
		rm -f $(depfile); \
		mv -f $(dot-target).tmp $(dot-target).cmd)
		mv -f $(dot-target).tmp $(dot-target).cmd, @:)

		# Usage: $(call if_changed_rule,foo)
		# Will check if $(cmd_foo) or any of the prerequisites changed,
		# and if so will execute $(rule_foo).
		if_changed_rule = $(if $(strip $(any-prereq) $(arg-check) ), \
		@set -e; \
		$(rule_$(1)))
		$(rule_$(1)), @:)

		###
		# why - tell why a a target got build

Admin message