Commit 2adc376c authored Jun 25, 2015 by Carlos Maiolino Committed by Al Viro Jun 30, 2015

vfs: avoid creation of inode number 0 in get_next_ino

currently, get_next_ino() is able to create inodes with inode number = 0.
This have a bad impact in the filesystems relying in this function to generate
inode numbers.

While there is no problem at all in having inodes with number 0, userspace tools
which handle file management tasks can have problems handling these files, like
for example, the impossiblity of users to delete these files, since glibc will
ignore them. So, I believe the best way is kernel to avoid creating them.

This problem has been raised previously, but the old thread didn't have any
other update for a year+, and I've seen too many users hitting the same issue
regarding the impossibility to delete files while using filesystems relying on
this function. So, I'm starting the thread again, with the same patch
that I believe is enough to address this problem.

Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent 06d7137e

fs/inode.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -840,7 +840,11 @@ unsigned int get_next_ino(void)
		}
		#endif

		*p = ++res;
		res++;
		/* get_next_ino should not provide a 0 inode number */
		if (unlikely(!res))
		res++;
		*p = res;
		put_cpu_var(last_ino);
		return res;
		}

Admin message