Commit 2acf5a3e authored Jun 27, 2019 by Colin Ian King Committed by Takashi Iwai Jun 28, 2019

ALSA: usb-audio: fix sign unintended sign extension on left shifts



There are a couple of left shifts of unsigned 8 bit values that
first get promoted to signed ints and hence get sign extended
on the shift if the top bit of the 8 bit values are set. Fix
this by casting the 8 bit values to unsigned ints to stop the
unintentional sign extension.

Addresses-Coverity: ("Unintended sign extension")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 503d90b3

sound/usb/mixer_quirks.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -754,7 +754,7 @@ static int snd_ni_control_init_val(struct usb_mixer_interface *mixer,
		return err;
		}

		kctl->private_value \|= (value << 24);
		kctl->private_value \|= ((unsigned int)value << 24);
		return 0;
		}

		@@ -915,7 +915,7 @@ static int snd_ftu_eff_switch_init(struct usb_mixer_interface *mixer,
		if (err < 0)
		return err;

		kctl->private_value \|= value[0] << 24;
		kctl->private_value \|= (unsigned int)value[0] << 24;
		return 0;
		}

Admin message