Commit 2aca5b86 authored Sep 24, 2014 by Trond Myklebust

SUNRPC: Add missing support for RPC_CLNT_CREATE_NO_RETRANS_TIMEOUT

The flag RPC_CLNT_CREATE_NO_RETRANS_TIMEOUT was intended introduced in
order to allow NFSv4 clients to disable resend timeouts. Since those
cause the RPC layer to break the connection, they mess up the duplicate
reply caches that remain indexed on the port number in NFSv4..

This patch includes the code that was missing in the original to
set the appropriate flag in struct rpc_clnt, when the caller of
rpc_create() sets RPC_CLNT_CREATE_NO_RETRANS_TIMEOUT.

Fixes: 8a19a0b6 (SUNRPC: Add RPC task and client level options to...)
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>

parent 2f3169fb

net/sunrpc/clnt.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -461,6 +461,8 @@ struct rpc_clnt rpc_create_xprt(struct rpc_create_args args,

		if (args->flags & RPC_CLNT_CREATE_AUTOBIND)
		clnt->cl_autobind = 1;
		if (args->flags & RPC_CLNT_CREATE_NO_RETRANS_TIMEOUT)
		clnt->cl_noretranstimeo = 1;
		if (args->flags & RPC_CLNT_CREATE_DISCRTRY)
		clnt->cl_discrtry = 1;
		if (!(args->flags & RPC_CLNT_CREATE_QUIET))
		@@ -579,6 +581,7 @@ static struct rpc_clnt __rpc_clone_client(struct rpc_create_args args,
		/* Turn off autobind on clones */
		new->cl_autobind = 0;
		new->cl_softrtry = clnt->cl_softrtry;
		new->cl_noretranstimeo = clnt->cl_noretranstimeo;
		new->cl_discrtry = clnt->cl_discrtry;
		new->cl_chatty = clnt->cl_chatty;
		return new;

Admin message