Commit 2ac757e4 authored Apr 27, 2020 by Wei Yongjun Committed by David S. Miller Apr 27, 2020

net: ethernet: ti: fix return value check in k3_cppi_desc_pool_create_name()



In case of error, the function gen_pool_create() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: 93a76530 ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0c2006b2

drivers/net/ethernet/ti/k3-cppi-desc-pool.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -64,8 +64,8 @@ k3_cppi_desc_pool_create_name(struct device *dev, size_t size,
		return ERR_PTR(-ENOMEM);

		pool->gen_pool = gen_pool_create(ilog2(pool->desc_size), -1);
		if (IS_ERR(pool->gen_pool)) {
		ret = PTR_ERR(pool->gen_pool);
		if (!pool->gen_pool) {
		ret = -ENOMEM;
		dev_err(pool->dev, "pool create failed %d\n", ret);
		kfree_const(pool_name);
		goto gen_pool_create_fail;

Admin message