Commit 2ab95749 authored Apr 20, 2015 by Sebastian Pöhn Committed by David S. Miller Apr 20, 2015

ip_forward: Drop frames with attached skb->sk



Initial discussion was:
[FYI] xfrm: Don't lookup sk_policy for timewait sockets

Forwarded frames should not have a socket attached. Especially
tw sockets will lead to panics later-on in the stack.

This was observed with TPROXY assigning a tw socket and broken
policy routing (misconfigured). As a result frame enters
forwarding path instead of input. We cannot solve this in
TPROXY as it cannot know that policy routing is broken.

v2:
Remove useless comment

Signed-off-by: Sebastian Poehn <sebastian.poehn@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 04b7fe6a

net/ipv4/ip_forward.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -82,6 +82,9 @@ int ip_forward(struct sk_buff *skb)
		if (skb->pkt_type != PACKET_HOST)
		goto drop;

		if (unlikely(skb->sk))
		goto drop;

		if (skb_warn_if_lro(skb))
		goto drop;

Admin message