Commit 2ab3a749 authored Mar 05, 2013 by Jean Delvare Committed by Linus Walleij Mar 27, 2013

gpio-ich: Fix value returned by ichx_gpio_request



Per Documentation/gpio.txt, gpio_request callbacks should return 0 on
success or a negative value on error. So it is not clear what was
meant by letting ichx_gpio_request return 1 in some cases, nor how a
caller would interpret it.

Align the code with the comment above it and consider pins as
available by default.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Grant Likely <grant.likely@secretlab.ca>
Acked-by: Peter Tyser <ptyser@xes-inc.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent a937536b

drivers/gpio/gpio-ich.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -214,7 +214,7 @@ static int ichx_gpio_request(struct gpio_chip *chip, unsigned nr)
		* If it can't be trusted, assume that the pin can be used as a GPIO.
		*/
		if (ichx_priv.desc->use_sel_ignore[nr / 32] & (1 << (nr & 0x1f)))
		return 1;
		return 0;

		return ichx_read_bit(GPIO_USE_SEL, nr) ? 0 : -ENODEV;
		}

Admin message