Commit 2aa4ee2a authored by Jim Kukunas's avatar Jim Kukunas Committed by NeilBrown
Browse files

lib/raid6: fix sparse warnings in recovery functions 



Make the recovery functions static to fix the following sparse warnings:

lib/raid6/recov.c:25:6: warning: symbol 'raid6_2data_recov_intx1' was
not declared. Should it be static?
lib/raid6/recov.c:69:6: warning: symbol 'raid6_datap_recov_intx1' was
not declared. Should it be static?
lib/raid6/recov_ssse3.c:22:6: warning: symbol 'raid6_2data_recov_ssse3'
was not declared. Should it be static?
lib/raid6/recov_ssse3.c:197:6: warning: symbol 'raid6_datap_recov_ssse3'
was not declared. Should it be static?

Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarJim Kukunas <james.t.kukunas@linux.intel.com>
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent 1e2aec87

lib/raid6/recov.c

+4 −3
Original line number Diff line number Diff line
@@ -22,8 +22,8 @@ 
#include <linux/raid/pq.h>



/* Recover two failed data blocks. */

void raid6_2data_recov_intx1(int disks, size_t bytes, int faila, int failb,

		       void **ptrs)

static void raid6_2data_recov_intx1(int disks, size_t bytes, int faila,

		int failb, void **ptrs)

{

	u8 *p, *q, *dp, *dq;

	u8 px, qx, db;
@@ -66,7 +66,8 @@ void raid6_2data_recov_intx1(int disks, size_t bytes, int faila, int failb, 
}



/* Recover failure of one data block plus the P block */

void raid6_datap_recov_intx1(int disks, size_t bytes, int faila, void **ptrs)

static void raid6_datap_recov_intx1(int disks, size_t bytes, int faila,

		void **ptrs)

{

	u8 *p, *q, *dq;

	const u8 *qmul;		/* Q multiplier table */

lib/raid6/recov_ssse3.c

+4 −3
Original line number Diff line number Diff line
@@ -19,8 +19,8 @@ static int raid6_has_ssse3(void) 
		boot_cpu_has(X86_FEATURE_SSSE3);

}



void raid6_2data_recov_ssse3(int disks, size_t bytes, int faila, int failb,

		       void **ptrs)

static void raid6_2data_recov_ssse3(int disks, size_t bytes, int faila,

		int failb, void **ptrs)

{

	u8 *p, *q, *dp, *dq;

	const u8 *pbmul;	/* P multiplier table for B data */
@@ -194,7 +194,8 @@ void raid6_2data_recov_ssse3(int disks, size_t bytes, int faila, int failb, 
}





void raid6_datap_recov_ssse3(int disks, size_t bytes, int faila, void **ptrs)

static void raid6_datap_recov_ssse3(int disks, size_t bytes, int faila,

		void **ptrs)

{

	u8 *p, *q, *dq;

	const u8 *qmul;		/* Q multiplier table */

CRA Git | Maintained and supported by SUSTech CRA and CCSE