Commit 2aa488a6 authored Nov 22, 2016 by Arnd Bergmann

misc: sram: remove useless #ifdef



A recent patch added a new function that is now unused whenever
CONFIG_OF is disabled:

drivers/misc/sram.c:342:12: error: 'atmel_securam_wait' defined but not used [-Werror=unused-function]

There is actually no reason for the #ifdef, because the driver
currently cannot be used in a meaningful way without CONFIG_OF,
and there is no compile-time dependency.

Removing that #ifdef and the respective of_match_ptr() avoids the
warning and simplifies the driver slightly.

Fixes: 2ae2e288 ("misc: sram: add Atmel securam support")
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

parent 11128b90

drivers/misc/sram.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -353,13 +353,11 @@ static int atmel_securam_wait(void)
		10000, 500000);
		}

		#ifdef CONFIG_OF
		static const struct of_device_id sram_dt_ids[] = {
		{ .compatible = "mmio-sram" },
		{ .compatible = "atmel,sama5d2-securam", .data = atmel_securam_wait },
		{}
		};
		#endif

		static int sram_probe(struct platform_device *pdev)
		{
		@@ -443,7 +441,7 @@ static int sram_remove(struct platform_device *pdev)
		static struct platform_driver sram_driver = {
		.driver = {
		.name = "sram",
		.of_match_table = of_match_ptr(sram_dt_ids),
		.of_match_table = sram_dt_ids,
		},
		.probe = sram_probe,
		.remove = sram_remove,

Admin message