Commit 2a9de3af authored Mar 11, 2020 by Torsten Hilbrich Committed by Steffen Klassert Mar 16, 2020

vti6: Fix memory leak of skb if input policy check fails



The vti6_rcv function performs some tests on the retrieved tunnel
including checking the IP protocol, the XFRM input policy, the
source and destination address.

In all but one places the skb is released in the error case. When
the input policy check fails the network packet is leaked.

Using the same goto-label discard in this case to fix this problem.

Fixes: ed1efb2a ("ipv6: Add support for IPsec virtual tunnel interfaces")
Signed-off-by: Torsten Hilbrich <torsten.hilbrich@secunet.com>
Reviewed-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>

parent d1d17a35

net/ipv6/ip6_vti.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -311,7 +311,7 @@ static int vti6_rcv(struct sk_buff *skb)

		if (!xfrm6_policy_check(NULL, XFRM_POLICY_IN, skb)) {
		rcu_read_unlock();
		return 0;
		goto discard;
		}

		ipv6h = ipv6_hdr(skb);

Admin message