Commit 2a93a0da authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Linus Walleij
Browse files

gpio: pca953x: Request IRQ after all initialisation done 



There is logically better to request IRQ when we initialise all structures.
Align the driver with the rest on the same matter.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200728125504.27786-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 5f402bb1

drivers/gpio/gpio-pca953x.c

+11 −11
Original line number Diff line number Diff line
@@ -865,17 +865,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base) 
	bitmap_and(chip->irq_stat, irq_stat, reg_direction, chip->gpio_chip.ngpio);

	mutex_init(&chip->irq_lock);



	ret = devm_request_threaded_irq(&client->dev, client->irq,

					NULL, pca953x_irq_handler,

					IRQF_ONESHOT | IRQF_SHARED,

					dev_name(&client->dev), chip);

	if (ret) {

		dev_err(&client->dev, "failed to request irq %d\n",

			client->irq);

		return ret;

	}



	irq_chip->name = dev_name(&chip->client->dev);

	irq_chip->name = dev_name(&client->dev);

	irq_chip->irq_mask = pca953x_irq_mask;

	irq_chip->irq_unmask = pca953x_irq_unmask;

	irq_chip->irq_set_wake = pca953x_irq_set_wake;
@@ -895,6 +885,16 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base) 
	girq->threaded = true;

	girq->first = irq_base; /* FIXME: get rid of this */



	ret = devm_request_threaded_irq(&client->dev, client->irq,

					NULL, pca953x_irq_handler,

					IRQF_ONESHOT | IRQF_SHARED,

					dev_name(&client->dev), chip);

	if (ret) {

		dev_err(&client->dev, "failed to request irq %d\n",

			client->irq);

		return ret;

	}



	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE