Commit 2a6cf944 authored Apr 30, 2013 by J. Bruce Fields

nfsd4: don't remap EISDIR errors in rename



We're going out of our way here to remap an error to make rfc 3530
happy--but the rfc itself (nor rfc 1813, which has similar language)
gives no justification.  And disagrees with local filesystem behavior,
with Linux and posix man pages, and knfsd's implemented behavior for v2
and v3.

And the documented behavior seems better, in that it gives a little more
information--you could implement the 3530 behavior using the posix
behavior, but not the other way around.

Also, the Linux client makes no attempt to remap this error in the v4
case, so it can end up just returning EEXIST to the application in a
case where it should return EISDIR.

So honestly I think the rfc's are just buggy here--or in any case it
doesn't see worth the trouble to remap this error.

Reported-by: Frank S Filz <ffilz@us.ibm.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

parent d28fcc83

fs/nfsd/nfs4proc.c

+5 −15

Original line number	Diff line number	Diff line
		@@ -813,21 +813,11 @@ nfsd4_rename(struct svc_rqst rqstp, struct nfsd4_compound_state cstate,
		status = nfsd_rename(rqstp, &cstate->save_fh, rename->rn_sname,
		rename->rn_snamelen, &cstate->current_fh,
		rename->rn_tname, rename->rn_tnamelen);

		/* the underlying filesystem returns different error's than required
		* by NFSv4. both save_fh and current_fh have been verified.. */
		if (status == nfserr_isdir)
		status = nfserr_exist;
		else if ((status == nfserr_notdir) &&
		(S_ISDIR(cstate->save_fh.fh_dentry->d_inode->i_mode) &&
		S_ISDIR(cstate->current_fh.fh_dentry->d_inode->i_mode)))
		status = nfserr_exist;

		if (!status) {
		if (status)
		return status;
		set_change_info(&rename->rn_sinfo, &cstate->current_fh);
		set_change_info(&rename->rn_tinfo, &cstate->save_fh);
		}
		return status;
		return nfs_ok;
		}

		static __be32

Admin message