Commit 2a5d2428 authored Feb 12, 2011 by Rafael J. Wysocki

ACPI / Wakeup: Enable button GPEs unconditionally during initialization

Commit 9630bdd9 (ACPI: Use GPE reference counting to support shared
GPEs) introduced a suspend regression where boxes resume immediately
after being suspended due to the lid or sleep button wakeup status
not being cleared properly.  This happens if the GPEs corresponding
to those devices are not enabled all the time, which apparently is
expected by some BIOSes.

To fix this problem, enable button and lid GPEs unconditionally
during initialization and keep them enabled all the time, regardless
of whether or not the ACPI button driver is used.

References: https://bugzilla.kernel.org/show_bug.cgi?id=27372


Reported-and-tested-by: Ferenc Wágner <wferi@niif.hu>
Cc: stable@kernel.org
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

parent 2d559513

drivers/acpi/wakeup.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -86,9 +86,13 @@ int __init acpi_wakeup_device_init(void)
		struct acpi_device *dev = container_of(node,
		struct acpi_device,
		wakeup_list);
		if (device_can_wakeup(&dev->dev))
		if (device_can_wakeup(&dev->dev)) {
		/* Button GPEs are supposed to be always enabled. */
		acpi_enable_gpe(dev->wakeup.gpe_device,
		dev->wakeup.gpe_number);
		device_set_wakeup_enable(&dev->dev, true);
		}
		}
		mutex_unlock(&acpi_device_lock);
		return 0;
		}

Admin message